Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(analytics): Track search events #241

Merged
merged 23 commits into from
Apr 25, 2023
Merged

feat(analytics): Track search events #241

merged 23 commits into from
Apr 25, 2023

Conversation

half0wl
Copy link
Member

@half0wl half0wl commented Apr 24, 2023

This tracks a new "Search Performed" goal in Fathom analytics. No search query is sent! (Fathom doesn't even support it)

While the cloud offering of Meilisearch has basic "analytics" that tells us how many searches are performed, it'd be nice to have this tracked over time.

Depends on #240.

@half0wl half0wl requested a review from ndneighbor April 24, 2023 12:33
Copy link
Contributor

@ndneighbor ndneighbor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamping with approval but I consider this a premature split from the main PR. This would be nice to have to the main branch when you merge in the above.

@half0wl
Copy link
Member Author

half0wl commented Apr 24, 2023

Stamping with approval but I consider this a premature split from the main PR. This would be nice to have to the main branch when you merge in the above.

They're split for easier reviews, testability, and easy reverts (generally speaking). They will be going out at the same time :-)

Base automatically changed from feat/new-search-ui to main April 25, 2023 08:21
@half0wl half0wl merged commit 6d3fee0 into main Apr 25, 2023
@half0wl half0wl deleted the feat/search-analytics branch April 25, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants